CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=5.0.0-beta.1 2019-12-04T15:29:57+00:00 2019-12-04T15:29:57+00:00 Jeff Epler jepler@gmail.com 2019-12-03T20:50:37+00:00 urn:sha1:238e12123690debaf2cf8488fb2a4d4003a06506 Protocols are nice, but there is no way for C code to verify whether a type's "protocol" structure actually implements some particular protocol. As a result, you can pass an object that implements the "vfs" protocol to one that expects the "stream" protocol, and the opposite of awesomeness ensues. This patch adds an OPTIONAL (but enabled by default) protocol identifier as the first member of any protocol structure. This identifier is simply a unique QSTR chosen by the protocol designer and used by each protocol implementer. When checking for protocol support, instead of just checking whether the object's type has a non-NULL protocol field, use `mp_proto_get` which implements the protocol check when possible. The existing protocols are now named: protocol_framebuf protocol_i2c protocol_pin protocol_stream protocol_spi protocol_vfs (most of these are unused in CP and are just inherited from MP; vfs and stream are definitely used though) I did not find any crashing examples, but here's one to give a flavor of what is improved, using `micropython_coverage`. Before the change, the vfs "ioctl" protocol is invoked, and the result is not intelligible as json (but it could have resulted in a hard fault, potentially): >>> import uos, ujson >>> u = uos.VfsPosix('/tmp') >>> ujson.load(u) Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: syntax error in JSON After the change, the vfs object is correctly detected as not supporting the stream protocol: >>> ujson.load(p) Traceback (most recent call last): File "<stdin>", line 1, in <module> OSError: stream operation not supported 2019-10-13T23:33:03+00:00 Dan Halbert halbert@halwitz.org 2019-10-13T23:10:58+00:00 urn:sha1:e89bcce7112a8ec70bd3f9d4f4097d1e7320ddde 2019-03-13T23:10:53+00:00 Scott Shawcroft scott@tannewt.org 2019-03-13T22:17:07+00:00 urn:sha1:6c01aba05b12c1f078197a45a711bcc5092b2a1c Such as moving files, adding directories and changing the label. 2019-03-13T23:10:52+00:00 Scott Shawcroft scott@tannewt.org 2019-03-13T22:07:19+00:00 urn:sha1:7482870164d614adb3de99f68d04535c3f035923 Fixes #1192 2019-02-21T22:15:50+00:00 Dan Halbert halbert@halwitz.org 2019-02-21T22:15:50+00:00 urn:sha1:d218069f03451e74e049b337830cbd1be7a25d8e Add option to disable the concurrent write protection 2019-02-21T21:24:07+00:00 Scott Shawcroft scott@tannewt.org 2019-02-21T21:24:07+00:00 urn:sha1:0261c57d32310a0c14703de3c197b700f9f401c3 rename ure, ujson, and uerrno to re, json, and errno 2019-02-21T20:11:54+00:00 Dan Halbert halbert@halwitz.org 2019-02-21T20:11:54+00:00 urn:sha1:01e5a82f1c157c4e170fec4b1e9d1bd1156e97fe 2019-02-21T18:45:41+00:00 Scott Shawcroft scott@tannewt.org 2019-02-19T22:45:45+00:00 urn:sha1:1a0596a2fbb68c1285ec59606d03a610ee94ca47 This allows writing to the filesystem from the host computer and CircuitPython by increasing the risk of filesystem corruption. 2019-02-21T16:09:44+00:00 Dan Halbert halbert@halwitz.org 2019-02-21T16:09:44+00:00 urn:sha1:10d3a20f8a639ad8ef5555e2142052190e8a7e13 2019-02-21T05:33:36+00:00 Dan Halbert halbert@halwitz.org 2019-02-21T05:33:36+00:00 urn:sha1:c5dbdbe88c099494cd14790b8c645020538eed27