suspect-devices/circuitpython/py/binary.c, branch 6.2.xCircuitPython - a Python implementation for teaching coding with microcontrollershttps://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=6.2.x2021-03-15T13:57:36+00:00run code formatting script2021-03-15T13:57:36+00:00microDev70126934+microDev1@users.noreply.github.com2021-03-15T13:57:36+00:00urn:sha1:a52eb88031620a81521b937f2a0651dbac2bb350modstruct: Improve compliance with python32020-09-12T19:07:23+00:00Jeff Eplerjepler@gmail.com2020-09-12T18:57:31+00:00urn:sha1:54d97251fe2dd4939652a186bf703885e654b4d1
While checking whether we can enable -Wimplicit-fallthrough, I encountered
a diagnostic in mp_binary_set_val_array_from_int which led to discovering
the following bug:
```
>>> struct.pack("xb", 3)
b'\x03\x03'
```
That is, the next value (3) was used as the value of a padding byte, while
standard Python always fills "x" bytes with zeros. I initially thought
this had to do with the unintentional fallthrough, but it doesn't.
Instead, this code would relate to an array.array with a typecode of
padding ('x'), which is ALSO not desktop Python compliant:
```
>>> array.array('x', (1, 2, 3))
array('x', [1, 0, 0])
```
Possibly this is dead code that used to be shared between struct-setting
and array-setting, but it no longer is.
I also discovered that the argument list length for struct.pack
and struct.pack_into were not checked, and that the length of binary data
passed to array.array was not checked to be a multiple of the element
size.
I have corrected all of these to conform more closely to standard Python
and revised some tests where necessary. Some tests for micropython-specific
behavior that does not conform to standard Python and is not present
in CircuitPython was deleted outright.
Add license to some obvious files.2020-07-06T18:16:25+00:00Diego Elio Pettenòflameeyes@flameeyes.com2020-06-03T22:40:05+00:00urn:sha1:34b4993d63a6b576f29d624385c681f679b4124cmp_binary_get_int: avoid undefined behavior2019-10-08T01:48:25+00:00Jeff Eplerjepler@gmail.com2019-10-08T01:48:25+00:00urn:sha1:0d96f1906b66139beebc13c55078aaf610c76968
Left shift of negative numbers is undefined in the "C" standard. Multiplying
by 256 has the intended effect (in the absence of integer overflow, anyway),
can be implemented using the same shift instruction, but does not invoke
undefined behavior.
This problem was found using clang 7's scan-build static analyzer.
Handle truth values; speed up smallint checks2019-05-12T04:10:53+00:00Dan Halberthalbert@halwitz.org2019-05-12T04:10:53+00:00urn:sha1:d103ac1d6325a075be3fafe812858584435f3144Add overflow checks for int to bytes conversions2019-05-09T07:22:25+00:00Matt Wozniskigodlygeek+git@gmail.com2019-05-09T03:50:35+00:00urn:sha1:095c844004bcd8680a4bf68901adbd9cac6a4302
For both small and long integers, raise an exception if calling
struct.pack, adding an element to an array.array, or formatting an int
with int.to_bytes would overflow the requested size.
Improve struct compatibility with CPython2019-01-20T20:12:34+00:00Dan Halberthalbert@halwitz.org2019-01-20T20:10:09+00:00urn:sha1:7a09af73ec7f4a11a1404dff6276e09072d06983Two fixes and translate more strings.2018-08-09T20:29:30+00:00Scott Shawcroftscott@tannewt.org2018-08-09T01:24:49+00:00urn:sha1:96ebf5bc3fb455162286b9bc31e763f3c4f1c457
* Fix finding translations with escaped characters.
* Add back \r to translations since its needed by screen.
merge finished2018-07-28T17:29:47+00:00Dan Halberthalbert@halwitz.org2018-07-28T17:29:47+00:00urn:sha1:f48b70050e3e4122eaae3eee47d35fc30bda2a4cConditionally compile out nonstandard array/struct typecodes2018-03-26T23:13:49+00:00Jeff Eplerjepler@unpythonic.net2018-03-26T23:13:49+00:00urn:sha1:355bf8b5538b4fe2f9f07b0d8fb2f4500c2f96c6
.. defaulting to off for circuitpython-supported boards, on for others.
.. fixing up the tests that fail when it is turned off, so that they skip
instead of failing