CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=main 2021-03-15T13:57:36+00:00 2021-03-15T13:57:36+00:00 microDev 70126934+microDev1@users.noreply.github.com 2021-03-15T13:57:36+00:00 urn:sha1:a52eb88031620a81521b937f2a0651dbac2bb350 2021-02-20T23:41:08+00:00 Jeff Epler jepler@gmail.com 2021-02-20T23:41:08+00:00 urn:sha1:a04369e0f58623079bc6f1f33f847e5c08b2d587 2021-02-20T16:35:36+00:00 Jeff Epler jepler@gmail.com 2021-02-20T16:35:27+00:00 urn:sha1:646eb9a7db654ebbbb8c1f85ba362a24db0dc77e 2020-09-12T19:07:23+00:00 Jeff Epler jepler@gmail.com 2020-09-12T18:57:31+00:00 urn:sha1:54d97251fe2dd4939652a186bf703885e654b4d1 While checking whether we can enable -Wimplicit-fallthrough, I encountered a diagnostic in mp_binary_set_val_array_from_int which led to discovering the following bug: ``` >>> struct.pack("xb", 3) b'\x03\x03' ``` That is, the next value (3) was used as the value of a padding byte, while standard Python always fills "x" bytes with zeros. I initially thought this had to do with the unintentional fallthrough, but it doesn't. Instead, this code would relate to an array.array with a typecode of padding ('x'), which is ALSO not desktop Python compliant: ``` >>> array.array('x', (1, 2, 3)) array('x', [1, 0, 0]) ``` Possibly this is dead code that used to be shared between struct-setting and array-setting, but it no longer is. I also discovered that the argument list length for struct.pack and struct.pack_into were not checked, and that the length of binary data passed to array.array was not checked to be a multiple of the element size. I have corrected all of these to conform more closely to standard Python and revised some tests where necessary. Some tests for micropython-specific behavior that does not conform to standard Python and is not present in CircuitPython was deleted outright. 2020-07-21T22:40:51+00:00 Scott Shawcroft scott@tannewt.org 2020-07-21T22:40:51+00:00 urn:sha1:6db10f9c7deba015dc89090f0957ebbd742cfa8e 2020-07-21T20:08:42+00:00 Scott Shawcroft scott@tannewt.org 2020-07-21T20:08:42+00:00 urn:sha1:900edb2b8e118ff36b708afe65363e5929f00ad8 2020-07-18T00:55:06+00:00 Scott Shawcroft scott@tannewt.org 2020-07-18T00:55:06+00:00 urn:sha1:f38a9c8d2991a94df9d629ae33ec25fa32b61af9 2020-07-18T00:07:37+00:00 Scott Shawcroft scott@tannewt.org 2020-07-16T00:59:11+00:00 urn:sha1:4b157aa6b8d925cbf29ceeb96da3a455f3a77f3b 2020-07-06T18:16:25+00:00 Diego Elio Pettenò flameeyes@flameeyes.com 2020-06-03T22:40:05+00:00 urn:sha1:34b4993d63a6b576f29d624385c681f679b4124c 2020-05-15T21:32:44+00:00 Thea Flowers me@thea.codes 2020-05-15T21:32:44+00:00 urn:sha1:0876034adb8487f45c88224cb1ce29743848244e