suspect-devices/circuitpython/py/objstr.c, branch v1.9.4CircuitPython - a Python implementation for teaching coding with microcontrollershttps://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=v1.9.42018-04-05T06:14:17+00:00py/objstr: In find/rfind, don't crash when end < start.2018-04-05T06:14:17+00:00Jeff Eplerjepler@gmail.com2018-04-01T02:27:56+00:00urn:sha1:d6cf5c674952d5ae3463d9b580dac6559576deacpy/runtime: Check that keys in dicts passed as ** args are strings.2018-03-30T00:13:32+00:00Damien Georgedamien.p.george@gmail.com2018-03-30T00:09:00+00:00urn:sha1:32807881954f106b9735de74fe984062a0815b81
Prior to this patch the code would crash if a key in a ** dict was anything
other than a str or qstr. This is because mp_setup_code_state() assumes
that keys in kwargs are qstrs (for efficiency).
Thanks to @jepler for finding the bug.
py/objstr: Remove unnecessary check for positive splits variable.2018-02-20T08:19:02+00:00Damien Georgedamien.p.george@gmail.com2018-02-20T08:19:02+00:00urn:sha1:8769049e935a89daa51883755457a083a5589d4e
At this point in the code the variable "splits" is guaranteed to be
positive due to the check for "splits == 0" above it.
py/objstr: Protect against creating bytes(n) with n negative.2018-02-19T05:25:30+00:00Damien Georgedamien.p.george@gmail.com2018-02-19T05:25:30+00:00urn:sha1:4e469085c192017c5244bbc115bac90f4bb667cb
Prior to this patch uPy (on a 32-bit arch) would have severe issues when
calling bytes(-1): such a call would call vstr_init_len(vstr, -1) which
would then +1 on the len and call vstr_init(vstr, 0), which would then
round this up and allocate a small amount of memory for the vstr. The
bytes constructor would then attempt to zero out all this memory, thinking
it had allocated 2^32-1 bytes.
py/unicode: Clean up utf8 funcs and provide non-utf8 inline versions.2018-02-14T07:19:22+00:00Damien Georgedamien.p.george@gmail.com2018-02-14T07:19:22+00:00urn:sha1:19aee9438a7a8cf8539536dab5147aedb6b16bb3
This patch provides inline versions of the utf8 helper functions for the
case when unicode is disabled (MICROPY_PY_BUILTINS_STR_UNICODE set to 0).
This saves code size.
The unichar_charlen function is also renamed to utf8_charlen to match the
other utf8 helper functions, and the signature of this function is adjusted
for consistency (const char* -> const byte*, mp_uint_t -> size_t).
py: Annotate func defs with NORETURN when their corresp decls have it.2017-11-29T04:43:40+00:00Damien Georgedamien.p.george@gmail.com2017-11-29T04:43:40+00:00urn:sha1:3990a52c0f071a7a48cc276f30785930f31eed39py/runtime: Add MP_BINARY_OP_CONTAINS as reverse of MP_BINARY_OP_IN.2017-11-24T03:48:23+00:00Damien Georgedamien.p.george@gmail.com2017-11-24T02:04:24+00:00urn:sha1:5e34a113eaaf736fb4f703a3ee0892e1705d0a63
Before this patch MP_BINARY_OP_IN had two meanings: coming from bytecode it
meant that the args needed to be swapped, but coming from within the
runtime meant that the args were already in the correct order. This lead
to some confusion in the code and comments stating how args were reversed.
It also lead to 2 bugs: 1) containment for a subclass of a native type
didn't work; 2) the expression "{True} in True" would illegally succeed and
return True. In both of these cases it was because the args to
MP_BINARY_OP_IN ended up being reversed twice.
To fix these things this patch introduces MP_BINARY_OP_CONTAINS which
corresponds exactly to the __contains__ special method, and this is the
operator that built-in types should implement. MP_BINARY_OP_IN is now only
emitted by the compiler and is converted to MP_BINARY_OP_CONTAINS by
swapping the arguments.
py/objstr: When constructing str from bytes, check for existing qstr.2017-11-16T03:02:28+00:00Damien Georgedamien.p.george@gmail.com2017-11-16T03:02:28+00:00urn:sha1:8d956c26d150749375115346f4ca319455107587
This patch uses existing qstr data where possible when constructing a str
from a bytes object.
py/objstr: Make mp_obj_new_str_of_type check for existing interned qstr.2017-11-16T02:53:04+00:00Damien Georgedamien.p.george@gmail.com2017-11-16T02:53:04+00:00urn:sha1:1f1d5194d775ad996f1d341c1a44b56af7ea4d4c
The function mp_obj_new_str_of_type is a general str object constructor
used in many places in the code to create either a str or bytes object.
When creating a str it should first check if the string data already exists
as an interned qstr, and if so then return the qstr object. This patch
makes the function have such behaviour, which helps to reduce heap usage by
reusing existing interned data where possible.
The old behaviour of mp_obj_new_str_of_type (which didn't check for
existing interned data) is made available through the function
mp_obj_new_str_copy, but should only be used in very special cases.
One consequence of this patch is that the following expression is now True:
'abc' is ' abc '.split()[0]
py/objstr: Remove "make_qstr_if_not_already" arg from mp_obj_new_str.2017-11-16T02:17:51+00:00Damien Georgedamien.p.george@gmail.com2017-11-16T02:17:51+00:00urn:sha1:4601759bf59e16b860a3f082e9aa4ea78356bf92
This patch simplifies the str creation API to favour the common case of
creating a str object that is not forced to be interned. To force
interning of a new str the new mp_obj_new_str_via_qstr function is added,
and should only be used if warranted.
Apart from simplifying the mp_obj_new_str function (and making it have the
same signature as mp_obj_new_bytes), this patch also reduces code size by a
bit (-16 bytes for bare-arm and roughly -40 bytes on the bare-metal archs).