suspect-devices/circuitpython/py/objstringio.c, branch master

protocols: Allow them to be (optionally) type-safe

2019-12-04T15:29:57+00:00

Protocols are nice, but there is no way for C code to verify whether a type's "protocol" structure actually implements some particular protocol. As a result, you can pass an object that implements the "vfs" protocol to one that expects the "stream" protocol, and the opposite of awesomeness ensues. This patch adds an OPTIONAL (but enabled by default) protocol identifier as the first member of any protocol structure. This identifier is simply a unique QSTR chosen by the protocol designer and used by each protocol implementer. When checking for protocol support, instead of just checking whether the object's type has a non-NULL protocol field, use `mp_proto_get` which implements the protocol check when possible. The existing protocols are now named: protocol_framebuf protocol_i2c protocol_pin protocol_stream protocol_spi protocol_vfs (most of these are unused in CP and are just inherited from MP; vfs and stream are definitely used though) I did not find any crashing examples, but here's one to give a flavor of what is improved, using `micropython_coverage`. Before the change, the vfs "ioctl" protocol is invoked, and the result is not intelligible as json (but it could have resulted in a hard fault, potentially): >>> import uos, ujson >>> u = uos.VfsPosix('/tmp') >>> ujson.load(u) Traceback (most recent call last): File "", line 1, in ValueError: syntax error in JSON After the change, the vfs object is correctly detected as not supporting the stream protocol: >>> ujson.load(p) Traceback (most recent call last): File "", line 1, in OSError: stream operation not supported

py changes for supporting superclass constructors that take kwargs

2019-01-15T01:29:19+00:00

Two fixes and translate more strings.

2018-08-09T20:29:30+00:00

* Fix finding translations with escaped characters. * Add back \r to translations since its needed by screen.

py/stream: Switch stream close operation from method to ioctl.

2018-04-10T03:41:32+00:00

This patch moves the implementation of stream closure from a dedicated method to the ioctl of the stream protocol, for each type that implements closing. The benefits of this are: 1. Rounds out the stream ioctl function, which already includes flush, seek and poll (among other things). 2. Makes calling mp_stream_close() on an object slightly more efficient because it now no longer needs to lookup the close method and call it, rather it just delegates straight to the ioctl function (if it exists). 3. Reduces code size and allows future types that implement the stream protocol to be smaller because they don't need a dedicated close method. Code size reduction is around 200 bytes smaller for x86 archs and around 30 bytes smaller for the bare-metal archs.

all: Remove inclusion of internal py header files.

2017-10-04T01:37:50+00:00

Header files that are considered internal to the py core and should not normally be included directly are: py/nlr.h - internal nlr configuration and declarations py/bc0.h - contains bytecode macro definitions py/runtime0.h - contains basic runtime enums Instead, the top-level header files to include are one of: py/obj.h - includes runtime0.h and defines everything to use the mp_obj_t type py/runtime.h - includes mpstate.h and hence nlr.h, obj.h, runtime0.h, and defines everything to use the general runtime support functions Additional, specific headers (eg py/objlist.h) can be included if needed.

py/objstringio: Fix regression with handling SEEK_SET.

2017-08-20T19:02:41+00:00

For SEEK_SET, offset should be treated as unsigned, to allow full-width stream sizes (e.g. 32-bit instead of 31-bit). This is now fully documented in stream.h. Also, seek symbolic constants are added.

py/objstringio: Prevent offset wraparound for io.BytesIO objects.

2017-08-20T19:00:05+00:00

Too big positive, or too big negative offset values could lead to overflow and address space wraparound and thus access to unrelated areas of memory (a security issue).

all: Use the name MicroPython consistently in comments

2017-07-31T08:35:40+00:00

There were several different spellings of MicroPython present in comments, when there should be only one.

py/objstringio: If created from immutable object, follow copy on write policy.

2017-06-09T14:33:01+00:00

Don't create copy of immutable object's contents until .write() is called on BytesIO.

py/objstringio: Catch mp_uint_t overflow of stream position in write().

2017-05-26T03:40:08+00:00