CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=5.0.0-alpha.5 2019-10-15T02:59:23+00:00 2019-10-15T02:59:23+00:00 Scott Shawcroft scott@tannewt.org 2019-10-15T02:59:23+00:00 urn:sha1:1610d06bb438961722c558bd695d6964c76cc080 2019-10-14T23:05:17+00:00 Scott Shawcroft scott@tannewt.org 2019-10-14T23:05:17+00:00 urn:sha1:9435e01f9e46ed212adf592b008f3036e16c0fbd Fixes #1763 2019-10-14T11:02:32+00:00 Jerry Needell jerryneedell@gmail.com 2019-10-14T11:02:32+00:00 urn:sha1:051670038eadc00c46da62f4020ee752bfab1659 2019-10-10T04:25:24+00:00 Jeff Epler jepler@gmail.com 2019-10-10T04:25:24+00:00 urn:sha1:cd0ed65b290b2a09b5df55daf02f8f1b44a916d9 2019-10-08T02:31:06+00:00 Jeff Epler jepler@gmail.com 2019-10-08T01:48:25+00:00 urn:sha1:8fbe19b99335da7c9a17698908f709b02901d8fc If kw_args is NULL then memcpy() gets a NULL source argument. This is undefined behavior under the C standard, even if 0 bytes are being copied. This problem was found using clang 7's scan-build static analyzer. 2019-10-08T02:16:11+00:00 Jeff Epler jepler@gmail.com 2019-10-08T01:48:25+00:00 urn:sha1:85f0048d22a31f34d991e56757560f1b39c007b6 Left shift of negative numbers is undefined in the "C" standard. Multiplying by 128 has the intended effect (in the absence of integer overflow, anyway), can be implemented using the same shift instruction, but does not invoke undefined behavior. This problem was found using clang 7's scan-build static analyzer. 2019-10-08T01:54:13+00:00 Jeff Epler jepler@gmail.com 2019-10-08T01:54:13+00:00 urn:sha1:46b6870ffac26fc360a00120a402535ed4ee836d The remaining assignment was added in upstream micropython; the deleted assignment was added in circuitpython as part of the long-lived object area feature. During the merge, the redundant assignment was not removed. (since collected is a local variable and no pointers to it escape, it doesn't seem possible for the placement of the assignment before or after GC_ENTER() is important) This diagnostic was found by clang 7's scan-build static analyzer. 2019-10-08T01:48:25+00:00 Jeff Epler jepler@gmail.com 2019-10-08T01:48:25+00:00 urn:sha1:0d96f1906b66139beebc13c55078aaf610c76968 Left shift of negative numbers is undefined in the "C" standard. Multiplying by 256 has the intended effect (in the absence of integer overflow, anyway), can be implemented using the same shift instruction, but does not invoke undefined behavior. This problem was found using clang 7's scan-build static analyzer. 2019-10-04T19:04:24+00:00 Hierophect hierophect@gmail.com 2019-10-04T19:01:33+00:00 urn:sha1:e017a5925d165fc5748e1f0a3f985339f3e75f88 2019-10-03T19:23:45+00:00 Hierophect hierophect@gmail.com 2019-10-03T19:23:45+00:00 urn:sha1:7a2f60c43deeea71f2fd86e2f22c812556e2aea7