CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=6.1.0-rc.0 2020-12-28T14:34:00+00:00 2020-12-28T14:34:00+00:00 microDev 70126934+microDev1@users.noreply.github.com 2020-12-28T14:34:00+00:00 urn:sha1:dc332baa87bf1fa3d777ffe31c7dc29b24a6a142 2020-12-22T01:46:30+00:00 Scott Shawcroft scott@adafruit.com 2020-12-22T01:46:30+00:00 urn:sha1:df8cba10682ad2a33a8ccb97350e82328be92bef displayio: Fix several bugs (transparency and palettes of OnDiskBitmaps) 2020-12-18T17:13:54+00:00 Jeff Epler jepler@gmail.com 2020-12-18T17:13:28+00:00 urn:sha1:6c4df5a8b45c6b20e00b5499c5db1d4f5da444a2 Closes #3795 2020-12-17T16:54:37+00:00 Jeff Epler jepler@gmail.com 2020-12-17T16:54:37+00:00 urn:sha1:f224ed18488b1e92b6d13b09b696769a2ac380ce Microsoft documentation says: > If biCompression equals BI_RGB and the bitmap uses 8 bpp or less, the bitmap has a color table immediatelly following the BITMAPINFOHEADER structure. The color table consists of an array of RGBQUAD values. The size of the array is given by the biClrUsed member. If biClrUsed is zero, the array contains the maximum number of colors for the given bitdepth; that is, 2^biBitCount colors. Formerly, we treated 0 colors as "no image palette" during construction, but then during common_hal_displayio_ondiskbitmap_get_pixel indexed into the palette anyway. This could have unpredictable results. On a pygamer, it gave an image that was blue and black. On magtag, it gave a crash. 2020-12-16T19:48:27+00:00 Jeff Epler jepler@gmail.com 2020-12-16T19:48:07+00:00 urn:sha1:28bd29eb42d61d0a7116b6c4295e166fcfbe7145 The transparent_color field was never initialized. I _think_ this means its value was always set to 0, or the blackest of blacks. Instead, initialize it to the sentinel value, newly given the name NO_TRANSPARENT_COLOR. This exposed a second problem: The test for whether there was an existing transparent color was wrong (backwards). I am guessing that this was not found due to the first bug; since the converter had a transparent color, the correct test would have led to always getting the error "Only one color can be transparent at a time". Closes #3723 2020-12-02T21:23:02+00:00 Scott Shawcroft scott@adafruit.com 2020-12-02T21:23:02+00:00 urn:sha1:1130b80e2ae173c5cb09dd3daa4b3acd61393611 Moving Adafruit_CircuitPython_BusDevice to core 2020-12-02T20:51:43+00:00 Scott Shawcroft scott@adafruit.com 2020-12-02T20:51:43+00:00 urn:sha1:d7ba641ff646b48e5ad38ff72a2dcfe17bb54624 Initial alarm and sleep PR: time alarms with light and deep sleep; PinAlarms not yet implemented 2020-12-01T21:47:16+00:00 Mark 56205165+gamblor21@users.noreply.github.com 2020-12-01T21:47:16+00:00 urn:sha1:237385798cb6989a5ed13e120c3cc5e2415af935 2020-11-28T16:54:34+00:00 Christian Walther cwalther@gmx.ch 2020-10-23T20:35:56+00:00 urn:sha1:7ca36d45a4ffe40c70814d62cb970007b7f40fee It not only caused crashes with requests larger than 64K (can happen with RGBMatrix), but also generated a lot longer code than necessary. 2020-11-28T16:54:34+00:00 Christian Walther cwalther@gmx.ch 2020-10-17T11:49:10+00:00 urn:sha1:a4b84cf0e118f06cc3b563866d5c594b94b9b3fb Hybrid allocation is now part of the infrastructure. Moving memory contents would not be necessary because displayio can recreate them, but does not hurt.