CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=6.1.0-rc.1 2021-01-12T15:23:07+00:00 2021-01-12T15:23:07+00:00 Jeff Epler jepler@gmail.com 2021-01-12T15:23:07+00:00 urn:sha1:1ca29ec47c9f51589faa151b659dfd1dd4a349ef 2021-01-05T19:19:11+00:00 iot49 49917707+iot49@users.noreply.github.com 2021-01-05T19:19:11+00:00 urn:sha1:1a82555803ab66bdb608508fccbcc9acc9bac657 2021-01-05T19:02:00+00:00 Bernhard Boser boser@berkeley.edu 2021-01-05T19:02:00+00:00 urn:sha1:79e3c3d2fd41b762679d6aa17522fb675f197773 2020-12-29T20:46:38+00:00 Jeff Epler jepler@gmail.com 2020-10-30T15:05:16+00:00 urn:sha1:a7542598a0ce1fbd7722312dd863b1d40b0c2837 2020-12-28T14:34:00+00:00 microDev 70126934+microDev1@users.noreply.github.com 2020-12-28T14:34:00+00:00 urn:sha1:dc332baa87bf1fa3d777ffe31c7dc29b24a6a142 2020-12-22T01:46:30+00:00 Scott Shawcroft scott@adafruit.com 2020-12-22T01:46:30+00:00 urn:sha1:df8cba10682ad2a33a8ccb97350e82328be92bef displayio: Fix several bugs (transparency and palettes of OnDiskBitmaps) 2020-12-20T03:06:43+00:00 Bernhard Boser boser@berkeley.edu 2020-12-20T03:06:43+00:00 urn:sha1:c875d7c22d447b9a29bcef62af7b46c902684d72 2020-12-18T17:13:54+00:00 Jeff Epler jepler@gmail.com 2020-12-18T17:13:28+00:00 urn:sha1:6c4df5a8b45c6b20e00b5499c5db1d4f5da444a2 Closes #3795 2020-12-17T16:54:37+00:00 Jeff Epler jepler@gmail.com 2020-12-17T16:54:37+00:00 urn:sha1:f224ed18488b1e92b6d13b09b696769a2ac380ce Microsoft documentation says: > If biCompression equals BI_RGB and the bitmap uses 8 bpp or less, the bitmap has a color table immediatelly following the BITMAPINFOHEADER structure. The color table consists of an array of RGBQUAD values. The size of the array is given by the biClrUsed member. If biClrUsed is zero, the array contains the maximum number of colors for the given bitdepth; that is, 2^biBitCount colors. Formerly, we treated 0 colors as "no image palette" during construction, but then during common_hal_displayio_ondiskbitmap_get_pixel indexed into the palette anyway. This could have unpredictable results. On a pygamer, it gave an image that was blue and black. On magtag, it gave a crash. 2020-12-16T19:48:27+00:00 Jeff Epler jepler@gmail.com 2020-12-16T19:48:07+00:00 urn:sha1:28bd29eb42d61d0a7116b6c4295e166fcfbe7145 The transparent_color field was never initialized. I _think_ this means its value was always set to 0, or the blackest of blacks. Instead, initialize it to the sentinel value, newly given the name NO_TRANSPARENT_COLOR. This exposed a second problem: The test for whether there was an existing transparent color was wrong (backwards). I am guessing that this was not found due to the first bug; since the converter had a transparent color, the correct test would have led to always getting the error "Only one color can be transparent at a time". Closes #3723