CircuitPython - a Python implementation for teaching coding with microcontrollers https://git.suspectdevices.com/suspect-devices/circuitpython/atom?h=6.2.x 2020-09-12T19:07:23+00:00 2020-09-12T19:07:23+00:00 Jeff Epler jepler@gmail.com 2020-09-12T18:57:31+00:00 urn:sha1:54d97251fe2dd4939652a186bf703885e654b4d1 While checking whether we can enable -Wimplicit-fallthrough, I encountered a diagnostic in mp_binary_set_val_array_from_int which led to discovering the following bug: ``` >>> struct.pack("xb", 3) b'\x03\x03' ``` That is, the next value (3) was used as the value of a padding byte, while standard Python always fills "x" bytes with zeros. I initially thought this had to do with the unintentional fallthrough, but it doesn't. Instead, this code would relate to an array.array with a typecode of padding ('x'), which is ALSO not desktop Python compliant: ``` >>> array.array('x', (1, 2, 3)) array('x', [1, 0, 0]) ``` Possibly this is dead code that used to be shared between struct-setting and array-setting, but it no longer is. I also discovered that the argument list length for struct.pack and struct.pack_into were not checked, and that the length of binary data passed to array.array was not checked to be a multiple of the element size. I have corrected all of these to conform more closely to standard Python and revised some tests where necessary. Some tests for micropython-specific behavior that does not conform to standard Python and is not present in CircuitPython was deleted outright. 2017-09-01T00:10:51+00:00 Damien George damien.p.george@gmail.com 2017-09-01T00:10:51+00:00 urn:sha1:793d826d9df67c3f544505beda63ca36d8dfa1c4 This patch makes a repeat counter behave the same as repeating the typecode, when there are not enough args. For example: struct.pack('2I', 1) now behave the same as struct.pack('II', 1). 2016-12-28T05:11:54+00:00 Rami Ali flowergrass@users.noreply.github.com 2016-12-28T04:29:21+00:00 urn:sha1:65574f817a949fea2316c335da866c1b8d20f1fb