diff options
| author | Damien George <damien.p.george@gmail.com> | 2019-08-19 15:50:02 +1000 |
|---|---|---|
| committer | Scott Shawcroft <scott@tannewt.org> | 2019-12-12 11:01:39 -0800 |
| commit | 63046d800d64081a4f7756476f5249179179ff5e (patch) | |
| tree | 63d200c7056424d05acce451a875f504aca45b50 | |
| parent | 887f64eed8d7c06182aa100a8131cc9b8b7dbd47 (diff) | |
py: Introduce MP_UNREACHABLE macro to annotate unreachable code.
And use it to replace the same pattern at the end of nlrthumb.c:nlr_jump.
| -rwxr-xr-x | py/mpconfig.h | 9 | ||||
| -rw-r--r-- | py/nlrthumb.c | 6 |
2 files changed, 10 insertions, 5 deletions
diff --git a/py/mpconfig.h b/py/mpconfig.h index 3ec383817..a0d211bfa 100755 --- a/py/mpconfig.h +++ b/py/mpconfig.h @@ -1440,6 +1440,15 @@ typedef double mp_float_t; #define MP_UNLIKELY(x) __builtin_expect((x), 0) #endif +// To annotate that code is unreachable +#ifndef MP_UNREACHABLE +#if defined(__GNUC__) +#define MP_UNREACHABLE __builtin_unreachable(); +#else +#define MP_UNREACHABLE for (;;); +#endif +#endif + #ifndef MP_HTOBE16 #if MP_ENDIANNESS_LITTLE # define MP_HTOBE16(x) ((uint16_t)( (((x) & 0xff) << 8) | (((x) >> 8) & 0xff) )) diff --git a/py/nlrthumb.c b/py/nlrthumb.c index 69d3f868a..eb32e2ce5 100644 --- a/py/nlrthumb.c +++ b/py/nlrthumb.c @@ -127,11 +127,7 @@ NORETURN void nlr_jump(void *val) { : // clobbered registers ); - #if defined(__GNUC__) - __builtin_unreachable(); - #else - for (;;); // needed to silence compiler warning - #endif + MP_UNREACHABLE } #endif // MICROPY_NLR_THUMB |
