diff options
| author | sw23 <sw23@users.noreply.github.com> | 2020-10-30 18:56:40 -0400 |
|---|---|---|
| committer | sw23 <sw23@users.noreply.github.com> | 2020-10-30 18:56:40 -0400 |
| commit | 6a63d20a5d2e7184bfc5747b465818fb7eee6b49 (patch) | |
| tree | d12719d74e96c35c8e1cc66da1e1507312c93261 | |
| parent | 09ae9aefa853ae20862eb7dd728e1e3187fc9135 (diff) | |
Fixing remaining stub mypy issues + run check-stubs to CI
| -rw-r--r-- | .github/workflows/build.yml | 2 | ||||
| -rw-r--r-- | shared-bindings/ipaddress/IPv4Address.c | 2 | ||||
| -rw-r--r-- | shared-bindings/socketpool/SocketPool.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 64d43f4d9..8039883e3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -68,7 +68,7 @@ jobs: run: MICROPY_CPYTHON3=python3.8 MICROPY_MICROPYTHON=../ports/unix/micropython_coverage ./run-tests -j1 --via-mpy -d basics float working-directory: tests - name: Stubs - run: make stubs -j2 + run: make check-stubs -j2 - uses: actions/upload-artifact@v2 with: name: stubs diff --git a/shared-bindings/ipaddress/IPv4Address.c b/shared-bindings/ipaddress/IPv4Address.c index b2a10158a..e027f32d6 100644 --- a/shared-bindings/ipaddress/IPv4Address.c +++ b/shared-bindings/ipaddress/IPv4Address.c @@ -126,7 +126,7 @@ const mp_obj_property_t ipaddress_ipv4address_version_obj = { (mp_obj_t)&mp_const_none_obj}, }; -//| def __eq__(self, other: IPv4Address) -> bool: +//| def __eq__(self, other: object) -> bool: //| """Two Address objects are equal if their addresses and address types are equal.""" //| ... //| diff --git a/shared-bindings/socketpool/SocketPool.c b/shared-bindings/socketpool/SocketPool.c index b737b5fc2..0cead525f 100644 --- a/shared-bindings/socketpool/SocketPool.c +++ b/shared-bindings/socketpool/SocketPool.c @@ -58,7 +58,7 @@ STATIC mp_obj_t socketpool_socketpool_make_new(const mp_obj_type_t *type, size_t } -//| def socket(self, family: int = AF_INET, type: int = SOCK_STREAM, proto: int = IPPROTO_TCP) -> None: +//| def socket(self, family: int, type: int, proto: int) -> socketpool.Socket: //| """Create a new socket //| //| :param ~int family: AF_INET or AF_INET6 |