summaryrefslogtreecommitdiff
path: root/shared-module
diff options
context:
space:
mode:
authorJeff Epler <jepler@gmail.com>2020-09-21 10:02:27 -0500
committerJeff Epler <jepler@gmail.com>2020-09-21 10:03:07 -0500
commit0318eb359fbeb91c6b37ed2050e57711ec2740bc (patch)
tree5eec9e870e8d3d91e1d1be2119e38e7b1c4a748c /shared-module
parent8eda9174b2e25b6fe99fc0a4b792fa1414915094 (diff)
makeqstrdata: Work around python3.6 compatibility problem
Discord user Folknology encountered a problem building with Python 3.6.9, `TypeError: ord() expected a character, but string of length 0 found`. I was able to reproduce the problem using Python3.5*, and discovered that the meaning of the regular expression `"|."` had changed in 3.7. Before, ``` >>> [m.group(0) for m in re.finditer("|.", "hello")] ['', '', '', '', '', ''] ``` After: ``` >>> [m.group(0) for m in re.finditer("|.", "hello")] ['', 'h', '', 'e', '', 'l', '', 'l', '', 'o', ''] ``` Check if `words` is empty and if so use `"."` as the regular expression instead. This gives the same result on both versions: ``` ['h', 'e', 'l', 'l', 'o'] ``` and fixes the generation of the huffman dictionary. Folknology verified that this fix worked for them. * I could easily install 3.5 but not 3.6. 3.5 reproduced the same problem
Diffstat (limited to 'shared-module')
0 files changed, 0 insertions, 0 deletions