summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Halbert <halbert@halwitz.org>2018-04-09 20:35:34 -0400
committerGitHub <noreply@github.com>2018-04-09 20:35:34 -0400
commit3883a9fb7adfbaa1864e2a40665dd8da5fc6a3cb (patch)
tree9a528baa69d6b6cd5b853e044de6edb8dc6a14be
parentd203d1c1cb238a819466a993525dd253028bf154 (diff)
parent619b0ec1646eef0b7de5ef5c30c0b5a576b484fc (diff)
Merge pull request #749 from tannewt/analyze_heap_dump
Fix rom qstr pool length.
-rw-r--r--tools/analyze_heap_dump.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/tools/analyze_heap_dump.py b/tools/analyze_heap_dump.py
index d5da884e4..55342ac69 100644
--- a/tools/analyze_heap_dump.py
+++ b/tools/analyze_heap_dump.py
@@ -56,8 +56,6 @@ SKIP_SYMBOLS = [".debug_ranges", ".debug_frame", ".debug_loc", ".comment", ".deb
help="Draw the heap layout")
@click.option("--draw-heap-ownership/--no-draw-heap-ownership", default=False,
help="Draw the ownership graph of blocks on the heap")
-@click.option("--draw-heap-ownership/--no-draw-heap-ownership", default=False,
- help="Draw the ownership graph of blocks on the heap")
@click.option("--analyze-snapshots", default="last", type=click.Choice(['all', 'last']))
def do_all_the_things(ram_filename, bin_filename, map_filename, print_block_contents,
print_unknown_types, print_block_state, print_conflicting_symbols,
@@ -352,7 +350,7 @@ def do_all_the_things(ram_filename, bin_filename, map_filename, print_block_cont
else:
rom_offset = pool_ptr - rom_start
prev, total_prev_len, alloc, length = struct.unpack_from("<IIII", rom[rom_offset:rom_offset+32])
- pool = rom[rom_offset:rom_offset+length*4]
+ pool = rom[rom_offset:rom_offset + 32 + length * 4]
if qstr_index >= total_prev_len:
offset = (qstr_index - total_prev_len) * 4 + 16