summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJensen <jensechu@gmail.com>2020-10-16 19:48:41 -0500
committerJensen <jensechu@gmail.com>2020-10-16 19:50:41 -0500
commit74c07a4bdcc942e57668f1a2181e00d1213864a7 (patch)
tree15edb115e19ac35cd97079915c6f8e5dc07ffe74
parentb02a5bcbd5eb96111ba30c49780677573fe1a66d (diff)
displayio: Add in opaque pixel option for future
-rw-r--r--locale/circuitpython.pot6
-rw-r--r--shared-bindings/displayio/ColorConverter.c8
-rw-r--r--shared-bindings/displayio/ColorConverter.h2
-rw-r--r--shared-module/displayio/ColorConverter.c4
4 files changed, 10 insertions, 10 deletions
diff --git a/locale/circuitpython.pot b/locale/circuitpython.pot
index c4b40d361..35143e04e 100644
--- a/locale/circuitpython.pot
+++ b/locale/circuitpython.pot
@@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2020-10-14 22:22-0500\n"
+"POT-Creation-Date: 2020-10-16 19:50-0500\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -3408,10 +3408,6 @@ msgstr ""
msgid "too many values to unpack (expected %d)"
msgstr ""
-#: shared-bindings/displayio/ColorConverter.c
-msgid "transparent_color should be an int"
-msgstr ""
-
#: extmod/ulab/code/approx/approx.c
msgid "trapz is defined for 1D arrays of equal length"
msgstr ""
diff --git a/shared-bindings/displayio/ColorConverter.c b/shared-bindings/displayio/ColorConverter.c
index 4e41ceff1..e47a961a5 100644
--- a/shared-bindings/displayio/ColorConverter.c
+++ b/shared-bindings/displayio/ColorConverter.c
@@ -125,12 +125,14 @@ MP_DEFINE_CONST_FUN_OBJ_2(displayio_colorconverter_make_transparent_obj, display
//| def make_opaque(self) -> None:
//| """Sets a pixel to opaque."""
//|
-STATIC mp_obj_t displayio_colorconverter_make_opaque(mp_obj_t self_in) {
+STATIC mp_obj_t displayio_colorconverter_make_opaque(mp_obj_t self_in, mp_obj_t transparent_color_obj) {
displayio_colorconverter_t *self = MP_OBJ_TO_PTR(self_in);
- common_hal_displayio_colorconverter_make_opaque(self);
+
+ mp_int_t transparent_color = mp_obj_get_int(&transparent_color);
+ common_hal_displayio_colorconverter_make_opaque(self, transparent_color);
return mp_const_none;
}
-MP_DEFINE_CONST_FUN_OBJ_1(displayio_colorconverter_make_opaque_obj, displayio_colorconverter_make_opaque);
+MP_DEFINE_CONST_FUN_OBJ_2(displayio_colorconverter_make_opaque_obj, displayio_colorconverter_make_opaque);
STATIC const mp_rom_map_elem_t displayio_colorconverter_locals_dict_table[] = {
{ MP_ROM_QSTR(MP_QSTR_convert), MP_ROM_PTR(&displayio_colorconverter_convert_obj) },
diff --git a/shared-bindings/displayio/ColorConverter.h b/shared-bindings/displayio/ColorConverter.h
index e4ddd1972..441f7c7ae 100644
--- a/shared-bindings/displayio/ColorConverter.h
+++ b/shared-bindings/displayio/ColorConverter.h
@@ -40,6 +40,6 @@ void common_hal_displayio_colorconverter_set_dither(displayio_colorconverter_t*
bool common_hal_displayio_colorconverter_get_dither(displayio_colorconverter_t* self);
void common_hal_displayio_colorconverter_make_transparent(displayio_colorconverter_t* self, uint32_t transparent_color);
-void common_hal_displayio_colorconverter_make_opaque(displayio_colorconverter_t* self);
+void common_hal_displayio_colorconverter_make_opaque(displayio_colorconverter_t* self, uint32_t transparent_color);
#endif // MICROPY_INCLUDED_SHARED_BINDINGS_DISPLAYIO_COLORCONVERTER_H
diff --git a/shared-module/displayio/ColorConverter.c b/shared-module/displayio/ColorConverter.c
index 4089b2265..d1a4f16a9 100644
--- a/shared-module/displayio/ColorConverter.c
+++ b/shared-module/displayio/ColorConverter.c
@@ -136,7 +136,9 @@ void common_hal_displayio_colorconverter_make_transparent(displayio_colorconvert
self->transparent_color = transparent_color;
}
-void common_hal_displayio_colorconverter_make_opaque(displayio_colorconverter_t* self) {
+void common_hal_displayio_colorconverter_make_opaque(displayio_colorconverter_t* self, uint32_t transparent_color) {
+ (void) transparent_color;
+
// 0x1000000 will never equal a valid color
self->transparent_color = 0x1000000;
}