summaryrefslogtreecommitdiff
path: root/shared-bindings
diff options
context:
space:
mode:
authorScott Shawcroft <scott@tannewt.org>2019-03-12 17:06:21 -0700
committerScott Shawcroft <scott@tannewt.org>2019-03-12 17:21:15 -0700
commit946790bfb53d69492f76b097aa07b1b45287631c (patch)
tree4f48211661da77d55fef8e627245f1355ac8bd36 /shared-bindings
parentafbf59019eec003ed79ee4467d0f3f76c00c68d2 (diff)
Add better PewPew error messages and update translations
Diffstat (limited to 'shared-bindings')
-rw-r--r--shared-bindings/_pew/PewPew.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/shared-bindings/_pew/PewPew.c b/shared-bindings/_pew/PewPew.c
index 50647488c..d7ae0116d 100644
--- a/shared-bindings/_pew/PewPew.c
+++ b/shared-bindings/_pew/PewPew.c
@@ -88,12 +88,12 @@ STATIC mp_obj_t pewpew_make_new(const mp_obj_type_t *type, size_t n_args,
mp_obj_get_array(args[ARG_cols].u_obj, &cols_size, &cols);
if (bufinfo.len != rows_size * cols_size) {
- mp_raise_ValueError(translate(""));
+ mp_raise_ValueError(translate("Incorrect buffer size"));
}
for (size_t i = 0; i < rows_size; ++i) {
if (!MP_OBJ_IS_TYPE(rows[i], &digitalio_digitalinout_type)) {
- mp_raise_TypeError(translate(""));
+ mp_raise_TypeError(translate("Row entry must be digitalio.DigitalInOut"));
}
digitalio_digitalinout_obj_t *pin = MP_OBJ_TO_PTR(rows[i]);
raise_error_if_deinited(
@@ -102,7 +102,7 @@ STATIC mp_obj_t pewpew_make_new(const mp_obj_type_t *type, size_t n_args,
for (size_t i = 0; i < cols_size; ++i) {
if (!MP_OBJ_IS_TYPE(cols[i], &digitalio_digitalinout_type)) {
- mp_raise_TypeError(translate(""));
+ mp_raise_TypeError(translate("Column entry must be digitalio.DigitalInOut"));
}
digitalio_digitalinout_obj_t *pin = MP_OBJ_TO_PTR(cols[i]);
raise_error_if_deinited(
@@ -111,7 +111,7 @@ STATIC mp_obj_t pewpew_make_new(const mp_obj_type_t *type, size_t n_args,
if (!MP_OBJ_IS_TYPE(args[ARG_buttons].u_obj,
&digitalio_digitalinout_type)) {
- mp_raise_TypeError(translate(""));
+ mp_raise_TypeError(translate("buttons must be digitalio.DigitalInOut"));
}
digitalio_digitalinout_obj_t *buttons = MP_OBJ_TO_PTR(
args[ARG_buttons].u_obj);
@@ -148,4 +148,3 @@ const mp_obj_type_t pewpew_type = {
.make_new = pewpew_make_new,
.locals_dict = (mp_obj_dict_t*)&pewpew_locals_dict,
};
-