diff options
| author | Scott Shawcroft <scott@tannewt.org> | 2019-04-08 17:02:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-08 17:02:07 -0700 |
| commit | 5015036c06e12c158ca0b36a23fade8da6fbbf07 (patch) | |
| tree | 0c11e4a7c4d090b5e0b6456f9e2e94aa97b6318b /shared-module/displayio | |
| parent | 672a102fdf5c86ca50146a3c6ea09cbc43a100bd (diff) | |
| parent | 049b9ca09493b9f88a86882379d140896050dc87 (diff) | |
Merge pull request #1758 from pewpew-game/fourwire-frequency
Stop hard-coding SPI frequency in FourWire
Diffstat (limited to 'shared-module/displayio')
| -rw-r--r-- | shared-module/displayio/FourWire.c | 7 | ||||
| -rw-r--r-- | shared-module/displayio/FourWire.h | 3 |
2 files changed, 8 insertions, 2 deletions
diff --git a/shared-module/displayio/FourWire.c b/shared-module/displayio/FourWire.c index 043f68e26..c87d2be95 100644 --- a/shared-module/displayio/FourWire.c +++ b/shared-module/displayio/FourWire.c @@ -40,6 +40,9 @@ void common_hal_displayio_fourwire_construct(displayio_fourwire_obj_t* self, self->bus = spi; common_hal_busio_spi_never_reset(self->bus); + self->frequency = common_hal_busio_spi_get_frequency(spi); + self->polarity = common_hal_busio_spi_get_polarity(spi); + self->phase = common_hal_busio_spi_get_phase(spi); common_hal_digitalio_digitalinout_construct(&self->command, command); common_hal_digitalio_digitalinout_switch_to_output(&self->command, true, DRIVE_MODE_PUSH_PULL); @@ -71,8 +74,8 @@ bool common_hal_displayio_fourwire_begin_transaction(mp_obj_t obj) { if (!common_hal_busio_spi_try_lock(self->bus)) { return false; } - // TODO(tannewt): Stop hardcoding SPI frequency, polarity and phase. - common_hal_busio_spi_configure(self->bus, 12000000, 0, 0, 8); + common_hal_busio_spi_configure(self->bus, self->frequency, self->polarity, + self->phase, 8); common_hal_digitalio_digitalinout_set_value(&self->chip_select, false); return true; } diff --git a/shared-module/displayio/FourWire.h b/shared-module/displayio/FourWire.h index 234bcf794..743139e62 100644 --- a/shared-module/displayio/FourWire.h +++ b/shared-module/displayio/FourWire.h @@ -38,6 +38,9 @@ typedef struct { digitalio_digitalinout_obj_t command; digitalio_digitalinout_obj_t chip_select; digitalio_digitalinout_obj_t reset; + uint32_t frequency; + uint8_t polarity; + uint8_t phase; } displayio_fourwire_obj_t; #endif // MICROPY_INCLUDED_ATMEL_SAMD_COMMON_HAL_DISPLAYIO_FOURWIRE_H |