Merge pull request #829 from jerryneedell/jerryn_i2c

add keyword timeout to I2C -- only used for bitbangioi

3 files changed, 14 insertions, 6 deletions

diff --git a/shared-module/bitbangio/I2C.c b/shared-module/bitbangio/I2C.c
index 7eeda0e00..47529748a 100644
--- a/shared-module/bitbangio/I2C.c
+++ b/shared-module/bitbangio/I2C.c
@@ -25,16 +25,15 @@
  */
 
 #include "shared-bindings/bitbangio/I2C.h"
-
 #include "py/mperrno.h"
 #include "py/obj.h"
+#include "py/runtime.h"
 
 #include "common-hal/microcontroller/Pin.h"
 #include "shared-bindings/microcontroller/__init__.h"
 #include "shared-bindings/digitalio/DigitalInOut.h"
 #include "shared-module/bitbangio/types.h"
 
-#define I2C_STRETCH_LIMIT 255
 
 STATIC void delay(bitbangio_i2c_obj_t *self) {
     // We need to use an accurate delay to get acceptable I2C
@@ -48,11 +47,16 @@ STATIC void scl_low(bitbangio_i2c_obj_t *self) {
 
 STATIC void scl_release(bitbangio_i2c_obj_t *self) {
     common_hal_digitalio_digitalinout_set_value(&self->scl, true);
+    uint32_t count = self->us_timeout;
     delay(self);
     // For clock stretching, wait for the SCL pin to be released, with timeout.
-    for (int count = I2C_STRETCH_LIMIT; !common_hal_digitalio_digitalinout_get_value(&self->scl) && count; --count) {
+    for (; !common_hal_digitalio_digitalinout_get_value(&self->scl) && count; --count) {
         common_hal_mcu_delay_us(1);
     }
+    // raise exception on timeout
+    if (count == 0) {
+        mp_raise_msg(&mp_type_TimeoutError, "Clock stretch too long");
+    }
 }
 
 STATIC void sda_low(bitbangio_i2c_obj_t *self) {
@@ -142,7 +146,10 @@ STATIC bool read_byte(bitbangio_i2c_obj_t *self, uint8_t *val, bool ack) {
 void shared_module_bitbangio_i2c_construct(bitbangio_i2c_obj_t *self,
                                            const mcu_pin_obj_t * scl,
                                            const mcu_pin_obj_t * sda,
-                                           uint32_t frequency) {
+                                           uint32_t frequency,
+                                           uint32_t us_timeout) {
+
+    self->us_timeout = us_timeout;
     self->us_delay = 500000 / frequency;
     if (self->us_delay == 0) {
         self->us_delay = 1;
diff --git a/shared-module/bitbangio/types.h b/shared-module/bitbangio/types.h
index dfe50f049..6d1723474 100644
--- a/shared-module/bitbangio/types.h
+++ b/shared-module/bitbangio/types.h
@@ -36,6 +36,7 @@ typedef struct {
     digitalio_digitalinout_obj_t scl;
     digitalio_digitalinout_obj_t sda;
     uint32_t us_delay;
+    uint32_t us_timeout;
     volatile bool locked;
 } bitbangio_i2c_obj_t;
 
diff --git a/shared-module/busio/I2C.c b/shared-module/busio/I2C.c
index 68d6ea22a..06e1af10a 100644
--- a/shared-module/busio/I2C.c
+++ b/shared-module/busio/I2C.c
@@ -30,8 +30,8 @@
 #include "py/nlr.h"
 
 void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
-        const mcu_pin_obj_t* scl, const mcu_pin_obj_t* sda, uint32_t freq) {
-    shared_module_bitbangio_i2c_construct(&self->bitbang, scl, sda, freq);
+        const mcu_pin_obj_t* scl, const mcu_pin_obj_t* sda, uint32_t freq, uint32_t timeout) {
+    shared_module_bitbangio_i2c_construct(&self->bitbang, scl, sda, freq, timeout);
 }
 
 bool common_hal_busio_i2c_deinited(busio_i2c_obj_t *self) {